From cb7ec6ff4cce50bf0e07a28ebb541038a56ec866 Mon Sep 17 00:00:00 2001 From: Lucas Sta Maria Date: Sat, 23 Aug 2025 22:50:20 +0800 Subject: [PATCH] fix: improve and add faces --- ghpr-review.el | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/ghpr-review.el b/ghpr-review.el index 03d91bd..3d3c1df 100644 --- a/ghpr-review.el +++ b/ghpr-review.el @@ -37,15 +37,25 @@ (require 'ghpr-utils) (defface ghpr-review-added-line - '((t (:background "green" :foreground "black"))) + '((t (:inherit diff-indicator-added))) "Face for added lines in PR diff." :group 'ghpr) (defface ghpr-review-removed-line - '((t (:background "red" :foreground "black"))) + '((t (:inherit diff-indicator-removed))) "Face for removed lines in PR diff." :group 'ghpr) +(defface ghpr-review-existing-review + '((t (:foreground "purple"))) + "Face for existing review comments." + :group 'ghpr) + +(defface ghpr-review-misc-line + '((t (:inherit diff-header))) + "Face for miscellaneous lines in PR diff." + :group 'ghpr) + (defvar ghpr-review-font-lock-keywords '(("^\\(> \\+[^+]\\)\\(.*\\)$" (0 'ghpr-review-added-line t)) @@ -54,7 +64,11 @@ ("^\\(> -[^-]\\)\\(.*\\)$" (0 'ghpr-review-removed-line t)) ("^\\(> -\\)$" ; Handle line with just "> -" - (0 'ghpr-review-removed-line t))) + (0 'ghpr-review-removed-line t)) + ("^<.*$" + (0 'ghpr-review-existing-review t)) + ("^>.*$" + (0 'ghpr-review-misc-line))) "Font lock keywords for ghpr-review-mode.") (defvar-local ghpr-review-diff-content nil