lucas/ghpr.el
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: confirm review submission and kill buffer on submit

Browse source
This commit is contained in:
Lucas Sta Maria 2025-08-27 17:17:36 +08:00
parent 22007c8a75
commit 9db3929117
Signed by: lucas
GPG key ID: F07FB16A826E3B47
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ghpr-review.el
View file

@ -393,13 +393,17 @@ Collects review body and inline comments from current buffer."
(or (not body) (string-empty-p (string-trim body)))) (or (not body) (string-empty-p (string-trim body))))
(error "Review body is required for %s events" event)) (error "Review body is required for %s events" event))
(unless (ghpr--create-review ghpr--review-repo-name (when (yes-or-no-p (format "Submit review (%s)? " event))
(if (ghpr--create-review ghpr--review-repo-name
pr-number pr-number
commit-sha commit-sha
(or body "") (or body "")
event event
api-comments) api-comments)
(message "Failed to submit review")))) (progn
(message "Review submitted successfully")
(kill-buffer (current-buffer)))
(message "Failed to submit review")))))
(defun ghpr-review-comment () (defun ghpr-review-comment ()
"Submit review comments with COMMENT event." "Submit review comments with COMMENT event."