lucas/ghpr.el
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: add magit-style ux for ghpr-prs

Browse source
This commit is contained in:
Lucas Sta Maria 2025-08-28 00:40:34 +08:00
parent a704736636
commit 9b9a8c5d07
Signed by: lucas
GPG key ID: F07FB16A826E3B47
3 changed files with 205 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

26
ghpr-review.el
View file

@ -128,16 +128,28 @@
(setq ghpr--review-repo-name repo-name)
(insert contents)))
(defun ghpr--open-pr (pr repo-name)
"Open a new buffer containing the body of the PR."
;; FIXME: this feels like poor separation of concerns
(defun ghpr--open-pr (pr repo-name &optional prs-list-buffer)
"Open a new buffer containing the body of the PR.
If PRS-LIST-BUFFER is provided, kill it after successfully opening the PR."
(let* ((number (alist-get 'number pr))
(buffer-name (format "*ghpr-pr-%s*" number))
(buffer (get-buffer-create buffer-name)))
(with-current-buffer buffer
(ghpr-review-mode)
(ghpr--open-pr/insert-contents pr repo-name)
(goto-char (point-min)))
(switch-to-buffer-other-window buffer)))
(condition-case err
(progn
(with-current-buffer buffer
(ghpr-review-mode)
(ghpr--open-pr/insert-contents pr repo-name)
(goto-char (point-min)))
(if prs-list-buffer
(switch-to-buffer buffer)
(switch-to-buffer-other-window buffer))
(when (and prs-list-buffer (buffer-live-p prs-list-buffer))
(kill-buffer prs-list-buffer)))
(error
(when (get-buffer buffer-name)
(kill-buffer buffer-name))
(signal (car err) (cdr err))))))
(defun ghpr--is-comment-line (line)
"Return t if LINE is a user comment (no prefix), nil otherwise."